Skip to content

feat: share API budget with parent streams #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 10, 2025
+31 −555
Merged

feat: share API budget with parent streams #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6cd208
share API budget with parent streams
maxi297 Nov 5, 2025
8b1541a
format/check
maxi297 Nov 5, 2025
d0ca8c6
re-add mistakenly removed assertion
maxi297 Nov 5, 2025
93a3bbe
Merge branch 'main' into maxi297/have_parent_streams_use_api_budget
maxi297 Nov 10, 2025
ec0d3f1
remove non thread safe test
maxi297 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,7 @@ def __init__(
connector_state_manager: Optional[ConnectorStateManager] = None,
max_concurrent_async_job_count: Optional[int] = None,
configured_catalog: Optional[ConfiguredAirbyteCatalog] = None,
api_budget: Optional[APIBudget] = None,
):
self._init_mappings()
self._limit_pages_fetched_per_slice = limit_pages_fetched_per_slice
Expand All @@ -695,7 +696,7 @@ def __init__(
configured_catalog
)
self._connector_state_manager = connector_state_manager or ConnectorStateManager()
self._api_budget: Optional[Union[APIBudget, HttpAPIBudget]] = None
self._api_budget: Optional[Union[APIBudget]] = api_budget
self._job_tracker: JobTracker = JobTracker(max_concurrent_async_job_count or 1)
# placeholder for deprecation warnings
self._collected_deprecation_logs: List[ConnectorBuilderLogMessage] = []
Expand Down Expand Up @@ -3887,6 +3888,7 @@ def create_parent_stream_config_with_substream_wrapper(
self._evaluate_log_level(self._emit_connector_builder_messages),
),
),
api_budget=self._api_budget,
)

return substream_factory.create_parent_stream_config(
Expand Down
Loading
Loading