🚨Source Zoho CRM: Migrate to poetry #42864
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
There was a problem hiding this comment.
@pabloescoder let's dust this off — if you resolve the conflicts and bump this to new base image, I'll be happy to re-run tests and send this over to progressive rollout.
| @@ -2,44 +2,46 @@ data: | |||
| ab_internal: | |||
| ql: 200 | |||
| sl: 100 | |||
| connectorBuildOptions: | |||
| baseImage: docker.io/airbyte/python-connector-base:2.0.0@sha256:c44839ba84406116e8ba68722a0f30e8f6e7056c726f447681bb9e9ece8bd916 | |||
There was a problem hiding this comment.
@pabloescoder can you bump this to 3.0 while we're here? I want to send this over to progressive rollout and see if we can ship this.
|
/format-fix
|
|
Just one failing acceptance test with incremental syncs with large state. It could be that this is OK as the cdk version is old. I’m okay shipping as is in progressive rollout @DanyloGL |
|
@natikgadzhi Did we do a progressive rollout for this? |
|
Incremental sync test fails. Trying to find good cloud connection for regression. |
|
We didn't start a rollout yet because we're scared of the incremental tests ;) @DanyloGL how can I help you get this in? |
|
Uh oh. Well, this is my bad. Brace for bug reports. UNLESS someone tells us we screwed up, let's roll forward and just fix the failing incremental sync problem |
What
Migrating the connector to Poetry
Can this PR be safely reverted and rolled back?