Source Apple Search Ads(fix): fix authentication grant_type #48440
+50
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
octavia-squidington-iii
added
area/connectors
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
One of our users alerted us to a bug in the Apple Search Ads connector's authentication, preventing them from connecting to the source. This PR implements the proposed fix by explicitly setting the grant_type to client_credentials (as well as some test metadata updates to fool CI into not complaining).
CAT tests were not implemented for this connector, as we do not have a sandbox account for this source. Since it is a medium usage connector and requires a CAT implementation, I stubbed in an implementation of the tests. I'm pushing this change on good faith since our users have more insight into this specific connector's health than I can verify myself 😅
How
User Impact
Unblock users with stuck connections
Can this PR be safely reverted and rolled back?