-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨feat(source-microsoft-sharepoint): Provide ability to sync other sites than Main sharepoint site #54658
base: master
Are you sure you want to change the base?
✨feat(source-microsoft-sharepoint): Provide ability to sync other sites than Main sharepoint site #54658
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@aldogonzalez8 - Thanks for working on it and it’s important feature. Is there a time line for this release ? |
/appprove-regression-tests |
/approve-regression-tests
|
@aldogonzalez8 - Is it possible to update the dependencies Pyarraw and requests to match the PyAirbyte version 0.23.0 ? |
@kkr2320 I need to document better this pr and connector official doc, after that will take a look in your request. |
/approve-regression-tests
|
@aldogonzalez8 Thanks again.. |
I believe it should work, I do something like:
That I understand translates to some GET like:
That I would expect that works 🤞 for "sites.read.all" or "sites.selected" scopes in the app. Maybe I need to adjust the scope to request both and let the app grant the available. |
What
Sharepoint portals are structured in a way so they can host multiple site. Currently connector only recognises files hosted in the main site and everything else is ignored.
We want to introduce the ability to sync other sites in sharepoint tenant.
How
This PR introduces a new optional
site_url
field to provide the URL to the sharepoint site for files to sync. If no value is provided it falls back to main site.Review guide
airbyte-integrations/connectors/source-microsoft-sharepoint/source_microsoft_sharepoint/stream_reader.py
: new get_site_drive method to get drives from either specific site_url or main site if no URL provided.User Impact
User will now be able to provide a sharepoint site alternative to main site.
Can this PR be safely reverted and rolled back?