Destination-S3: Enable optional fallback to legacy java SDK #54731
+239
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
johnny-schmidt
force-pushed
the
jschmidt/s3/possible-to-use-legacy-cdk
branch
from
c1fe7e0 to
4117fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds an option to enable the legacy S3 java SDK. This is to facilitate file transfer testing, but also to have it as an option for performance tuning the existing S3 destination. (There is evidence the new SDK artificially limits the amount of concurrent due to a bug in the underlying timeout retry protocol.)
The option is current disabled and not exposed on the configuration, but it can be set by setting
ObjectStorageUploadConfiguration.useLegacyJavaClient = true.Tested locally with the new S3 Destination connector, all ITs are green.
Initialization code / dependencies are copied from the old SDK.