Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix popups being covered by page scrollbar #5763

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nightwing
Copy link
Member

Fixes the issue where autocomplete popup and doc tooltip could be covered by page scrollbar, or could extend outside of viewport.

@nightwing nightwing force-pushed the fix-popup-positioning branch 2 times, most recently from b7f9429 to 1ef1ed7 Compare March 5, 2025 09:38
@nightwing nightwing force-pushed the fix-popup-positioning branch from 1ef1ed7 to e55d8bd Compare March 5, 2025 09:43
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 62.22222% with 17 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (cd78a94) to head (e55d8bd).

Files with missing lines Patch % Lines
src/autocomplete.js 55.26% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5763      +/-   ##
==========================================
- Coverage   87.10%   87.09%   -0.02%     
==========================================
  Files         602      602              
  Lines       44092    44114      +22     
  Branches     7234     7240       +6     
==========================================
+ Hits        38407    38420      +13     
- Misses       5685     5694       +9     
Flag Coverage Δ
unittests 87.09% <62.22%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant