Skip to content

Commit

Permalink
Placeholder open new view
Browse files Browse the repository at this point in the history
  • Loading branch information
ajthinking committed Jan 12, 2025
1 parent 6fe86ab commit 2312f53
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 4 deletions.
2 changes: 2 additions & 0 deletions packages/ds-ext/src/DiagramEditorProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { observeNodeStatus } from './messageHandlers/observeNodeStatus';
import { observeLinkUpdate } from './messageHandlers/observeLinkUpdate';
import { getDataFromStorage } from './messageHandlers/getDataFromStorage';
import { cancelObservation } from './messageHandlers/cancelObservation';
import { onEdgeDoubleClick } from './messageHandlers/onEdgeDoubleClick';
import { DuckDBStorage } from './duckDBStorage';
import { FileStorage } from './fileStorage';
import { loadConfig } from './loadConfig';
Expand Down Expand Up @@ -113,6 +114,7 @@ export class DiagramEditorProvider implements vscode.CustomEditorProvider<Diagra
observeLinkUpdate,
getDataFromStorage,
cancelObservation,
onEdgeDoubleClick,
};

const handler = handlers[event.type];
Expand Down
16 changes: 16 additions & 0 deletions packages/ds-ext/src/messageHandlers/onEdgeDoubleClick.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { MessageHandler } from '../MessageHandler';
import * as vscode from 'vscode';
import * as path from 'path';
import * as fs from 'fs';

export const onEdgeDoubleClick: MessageHandler = async ({ event }) => {
const workspaceRoot = vscode.workspace.workspaceFolders?.[0]?.uri.fsPath || '';
const tempFilePath = path.join(workspaceRoot, 'temp_table_view.txt');

const content = `TODO: open the Table component here. Use the edge id (${event.edgeId}) to get the relevant data`;

fs.writeFileSync(tempFilePath, content);

const document = await vscode.workspace.openTextDocument(tempFilePath);
await vscode.window.showTextDocument(document, { preview: false });
};
6 changes: 2 additions & 4 deletions packages/ui/src/components/DataStory/DataStoryCanvas.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,8 @@ const Flow = ({
onNodeDoubleClick?.(node);
}}
onEdgeDoubleClick={(event, edge) => {
console.log({
msg: 'Edge double click',
edgeId: edge.id,
})
if (!client) return;
if(client.onEdgeDoubleClick) client.onEdgeDoubleClick(edge.id);
}}
onEdgesChange={(changes: EdgeChange[]) => {
onEdgesChange(changes);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,13 @@ export class WorkspaceApiClient implements WorkspaceApiClientImplement {
msg$.subscribe(this.receivedMsg$);
}

onEdgeDoubleClick(edgeId: string): void {
this.transport.sendAndReceive({
type: 'onEdgeDoubleClick',
edgeId
});
}

//<editor-fold desc="Message init">
private initExecutionResult() {
return this.receivedMsg$.pipe(filter(matchMsgType('ExecutionResult')))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ export interface WorkspaceApiClientImplement {
observeNodeStatus?: (params: ObserveNodeStatus) => Subscription;
getDataFromStorage?: (params: GetDataFromStorageParams) => Promise<Record<LinkId, ItemValue[]>>;
cancelObservation?:(params: CancelObservation) => Promise<void>;
onEdgeDoubleClick?: (edgeId: string) => void;
}

0 comments on commit 2312f53

Please sign in to comment.