fix: Prevent crash when pasting empty clipboard data in DataStory

ajthinking · Feb 21, 2025 · b697536 · b697536
1 parent 9f14ef9
commit b697536
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/ui/src/components/DataStory/common/clipboard.ts b/packages/ui/src/components/DataStory/common/clipboard.ts
@@ -15,14 +15,15 @@ export const writeToClipboard = ({
     }),
   );
 }
+
 export const readFromClipboard = async(): Promise<{ nodes: SNode[]; edges: SEdge[] }> => {
   let nodes: SNode[] = [];
   let edges: SEdge[] = [];
   try {
     // Read from system clipboard
     const text = await navigator.clipboard.readText();
-    nodes = JSON.parse(text).nodes;
-    edges = JSON.parse(text).edges;
+    nodes = JSON.parse(text).nodes ?? [];
+    edges = JSON.parse(text).edges ?? [];
   } catch(e) {
     console.warn('Error reading from clipboard', e);
   }

diff --git a/packages/ui/src/components/DataStory/useCopyPaste.ts b/packages/ui/src/components/DataStory/useCopyPaste.ts
@@ -80,6 +80,7 @@ export function useCopyPaste() {
     const generateCopiedId = (originalId: string) => `${originalId}-${now}`;
 
     const { nodes: copiedNodes, edges: copiedEdges } = await readFromClipboard();
+    if (!copiedNodes?.length) return;
 
     const calculateNewPosition = (originalPos: XYPosition) => ({
       x: position.x + (originalPos.x - Math.min(...copiedNodes.map(n => n.position.x))),