Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use semantic string aliases #362

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Use semantic string aliases #362

merged 1 commit into from
Jan 8, 2025

Conversation

ajthinking
Copy link
Owner

@ajthinking ajthinking commented Jan 8, 2025

Prefer NodeId, LinkId, PortId over string.
Gives semantic meaning.
Future proofs the type usage, if in future we would like to refactor to something like

export type LinkId = `${string}-${number}`;

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-story-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 7:18am

@ajthinking ajthinking merged commit 24eda6c into main Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant