Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve "webView is disposed" issue when the webView is still being used #365

Merged
merged 5 commits into from
Jan 11, 2025
Merged

fix: resolve "webView is disposed" issue when the webView is still being used #365

merged 5 commits into from
Jan 11, 2025

Conversation

stone-lyl
Copy link
Collaborator

Before After
❌ ✅
fix: Resolve file path issues on Windows systems containing colons fix: Resolve file path issues on Windows systems containing colons
image image
  • fix: resolve "webView is disposed" issue when the webView is still being used
    before:
    image

after:

dispose-webview-success.mp4

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-story-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 4:03am

@stone-lyl stone-lyl requested a review from ajthinking January 10, 2025 08:56
@ajthinking ajthinking merged commit d534cad into ajthinking:main Jan 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajthinking ajthinking ajthinking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stone-lyl @ajthinking