-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement copy, paste, cut, and select all functionality for node/edge management #382
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good 👍 Lets address the issues commented before. Feels like things related to ids not being unique?
The issues have been resolved. |
These issues are likely related to the IDs, but they are indeed unique. |
In addition to the issues mentioned above, I tested the new feature, identified, and fixed the following problems: When modifying the parameters of a copied signal node, the parameters of the original node also change. before: 2025-02-20-15-34-57.mp4Since we've modified the edge, we can't use the original code of |
Ctrl+C
,Ctrl+V
, andCtrl+X
, allowing users to easily copy, paste, and cut nodes.nodes
by holding down theCtrl
key, and when copying, both the selectednodes
and their correspondingedges
will be copied together.Component id
Issue: The copiedComponent id
is currently not unique, leading to repetition that needs to be addressed.node
Selection Feedback: Especially fortable
typenodes
, the selection feedback is not clearly visible, which could be improved for a better user experience.2025-02-19-21-28-47.mp4
Todo:
diagram
information.nodes
, which interferes with copying text in the Sidebar andResource
andDataStory
text on the page.