Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved the issue of the disappearing styles #94

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

stone-lyl
Copy link
Collaborator

  • problem: It appears that Nextra has a global stylesheet that interferes with other stylesheets. Global stylesheet breaks Amplify · Issue #2442 · shuding/nextra

  • temporary solution: by bundling with style-loader, the priority of the styles in the UI layer has been elevated, which can temporarily mask this problem.

  • potential risk: other Project A is utilizing data-story/ui, and it also incorporates tailwind as its styling framework. If both A and ui use the default class names of tailwind, their styles might conflict. The final rendering effect depends on which project's style tag is inserted later, as the style inserted later has a higher priority.

Before After
image image

Copy link

vercel bot commented Dec 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
data-story-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 2:39am

Copy link
Owner

@ajthinking ajthinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for now 👍

@stone-lyl stone-lyl merged commit 18861b4 into ajthinking:main Dec 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants