Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenAPI 3.0 discriminator.mapping #2263

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

z6n9n
Copy link

@z6n9n z6n9n commented May 1, 2023

What issue does this pull request resolve?
resolves #2003

What changes did you make?
option to ignore additional mappings for discriminator. Mappings are not needed in AJV, but they are passed from OAS and should be ignored.

Is there anything that requires more attention while reviewing?
The provided documentation

@zekth
Copy link
Contributor

zekth commented Nov 13, 2023

@epoberezkin could you check this PR?

@jeffmay
Copy link

jeffmay commented Jan 30, 2024

@epoberezkin Any update on this one? I'm about to implement a work-around using extensions and jq to transform the spec (since oapi-codegen requires the mappings object, but it would be nice to be able to produce a spec that doesn't require these extensions.

@afmhenry
Copy link

I've been running into this issue as well--is this being reviewed/considered for approval?

@VolodymyrMachekhin
Copy link

I have to use patch as a workaround while it is not approved

@samkim130
Copy link

@epoberezkin bump on this! Seems like a feasible solution

@Typiqally
Copy link

Hi @jeffmay or @VolodymyrMachekhin, could you explain how you applied the work around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support OpenAPI 3.0 discriminator.mapping
8 participants