Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analytics): integrates amplitude #850

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ygrishajev
Copy link
Contributor

also hides analytic reporters behind a single interface

@ygrishajev ygrishajev requested a review from a team as a code owner February 14, 2025 12:12
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 32.17391% with 78 lines in your changes missing coverage. Please review.

Project coverage is 22.52%. Comparing base (75377c2) to head (15961c6).

Files with missing lines Patch % Lines
...ploy-web/src/components/templates/UserTemplate.tsx 0.00% 8 Missing ⚠️
...oy-web/src/components/sdl/SimpleSdlBuilderForm.tsx 0.00% 6 Missing ⚠️
...s/deploy-web/src/components/sdl/ImportSdlModal.tsx 0.00% 4 Missing ⚠️
...CertificateProvider/CertificateProviderContext.tsx 20.00% 4 Missing ⚠️
...-web/src/context/WalletProvider/WalletProvider.tsx 20.00% 4 Missing ⚠️
.../components/deployments/DeploymentDetailTopBar.tsx 0.00% 3 Missing ⚠️
...b/src/components/deployments/DeploymentListRow.tsx 0.00% 3 Missing ⚠️
...eploy-web/src/components/liquidity-modal/index.tsx 0.00% 3 Missing ⚠️
...-web/src/components/new-deployment/CreateLease.tsx 0.00% 3 Missing ⚠️
...eploy-web/src/components/sdl/SaveTemplateModal.tsx 0.00% 3 Missing ⚠️
... and 21 more

❌ Your patch status has failed because the patch coverage (32.17%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #850       +/-   ##
===========================================
+ Coverage   11.33%   22.52%   +11.19%     
===========================================
  Files         439      639      +200     
  Lines       11594    16059     +4465     
  Branches     2443     3087      +644     
===========================================
+ Hits         1314     3618     +2304     
- Misses       9720    11708     +1988     
- Partials      560      733      +173     
Flag Coverage Δ
api 53.58% <ø> (?)
deploy-web 8.91% <32.17%> (+0.19%) ⬆️
provider-proxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

also hides analytic reporters behind a single interface
@anilmurty
Copy link

awesome!
For a moment I thought you are disabling GA but seems like it's only disabled for dev and staging but not for prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants