-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement SystemInformationApi for the GET endpoint /api/rest/v1/system-information #279
Implement SystemInformationApi for the GET endpoint /api/rest/v1/system-information #279
Conversation
What are the next steps to get this PR approved ? |
Hello @tomglvng, |
Hello @ConstantBqt , Thank you so much for your contribution! To continue the merge process, we would need you to sign our Contributor License Agreement kindly. Please find it here: https://www.akeneo.com/contributor-license-agreement/ Looking forward to reading you, The Akeneo development team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you launch tests?
make tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add tests for this class. Get inspiration with spec/Api/AttributeGroupApiSpec.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tomglvng
I added SystemInformationApiSpec
and fix the AkeneoPimClientSpec
in my last commit.
The result of make tests
is successful
Thanks 🙏
Hello, Any updates regarding this PR @tomglvng ? I would be interested by this new endpoint too. Thanks ;-) |
CI is green so merging it should be ok. Waiting for @tomglvng review |
Hello @ConstantBqt , SOrry for the delay. I created a PR to merge your contribution. I'm waiting for the review. Could you have a look @lasdou ? |
@ConstantBqt merged! Thanks for your contribution ;) |
Get the data from this endpoint https://api.akeneo.com/api-reference.html#get_system_information
Available in PIM versions: 6.0, 7.0 and SaaS