Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SystemInformationApi for the GET endpoint /api/rest/v1/system-information #279

Closed

Conversation

ConstantBqt
Copy link

Get the data from this endpoint https://api.akeneo.com/api-reference.html#get_system_information

Available in PIM versions: 6.0, 7.0 and SaaS

@ConstantBqt
Copy link
Author

What are the next steps to get this PR approved ?

@ConstantBqt
Copy link
Author

Hello @tomglvng,
I saw your name as reviewer for another PR of this repository. Could you please review this PR when you get a chance ?
Thanks a lot !

@tomglvng
Copy link
Collaborator

Hello @tomglvng, I saw your name as reviewer for another PR of this repository. Could you please review this PR when you get a chance ? Thanks a lot!

Hello @ConstantBqt ,

Thank you so much for your contribution! To continue the merge process, we would need you to sign our Contributor License Agreement kindly. Please find it here: https://www.akeneo.com/contributor-license-agreement/

Looking forward to reading you,

The Akeneo development team

Copy link
Collaborator

@tomglvng tomglvng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you launch tests?
make tests

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add tests for this class. Get inspiration with spec/Api/AttributeGroupApiSpec.php

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tomglvng
I added SystemInformationApiSpec and fix the AkeneoPimClientSpec in my last commit.
The result of make tests is successful

Thanks 🙏

@lasdou
Copy link

lasdou commented May 13, 2024

Hello, Any updates regarding this PR @tomglvng ? I would be interested by this new endpoint too. Thanks ;-)

@lasdou
Copy link

lasdou commented May 13, 2024

CI is green so merging it should be ok. Waiting for @tomglvng review

@tomglvng
Copy link
Collaborator

#292

@tomglvng
Copy link
Collaborator

Hello @ConstantBqt , SOrry for the delay. I created a PR to merge your contribution. I'm waiting for the review. Could you have a look @lasdou ?

@tomglvng
Copy link
Collaborator

@ConstantBqt merged! Thanks for your contribution ;)

@tomglvng tomglvng closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants