Increase patience config #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasi35
commented
Feb 25, 2021
| @@ -400,6 +404,8 @@ class ClusterHttpManagementRoutesSpec | |||
|
|
|||
| import scala.concurrent.duration._ | |||
|
|
|||
| implicit val patience: PatienceConfig = PatienceConfig(timeout = Span(3, Seconds), interval = Span(50, Millis)) | |||
There was a problem hiding this comment.
The flaky test in #848 doesn't seem to do anything fancier than any other test in that Spec so I suspect this PatienceConfig is not the fix.
| @@ -443,7 +449,7 @@ class ClusterHttpManagementRoutesSpec | |||
| .futureValue(t) | |||
| responseGetDomainEvents.status shouldEqual StatusCodes.OK | |||
| val responseGetDomainEventsData = responseGetDomainEvents.entity.dataBytes | |||
| .takeWithin(100.millis) | |||
| .takeWithin(500.millis) | |||
There was a problem hiding this comment.
I suspect this is the actual fix since taking events during a longer period is likely to obtain the one we're looking for.
ignasi35
force-pushed
the
increase-patience-config
branch
from
87c0c50 to
c588b49
Compare
ignasi35
force-pushed
the
increase-patience-config
branch
from
dcc2ed3 to
3ab1f78
Compare
|
Rebased over #859 |
ignasi35
changed the base branch from
master
to
wip-chbatey-bootstrap-port-conflicts
Base automatically changed from
wip-chbatey-bootstrap-port-conflicts
to
master
February 25, 2021 16:38
chbatey
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A blind shot at fixing #848