fixed bugs with multiple Members with same Address crashing ClusterDaemon
#7371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
Oct 30, 2024
| @@ -1635,22 +1635,22 @@ public void Welcome(Address joinWith, UniqueAddress from, Gossip gossip) | |||
| public void Leaving(Address address) | |||
| { | |||
| // only try to update if the node is available (in the member ring) | |||
| if (LatestGossip.Members.Any(m => m.Address.Equals(address) && m.Status is MemberStatus.Joining or MemberStatus.WeaklyUp or MemberStatus.Up)) | |||
| foreach(var mem in LatestGossip.Members.Where(m => m.Address.Equals(address))) | |||
There was a problem hiding this comment.
TLDR - iterate over each Member with the same Address and filter them one at a time - don't do what we did before, which is to check if there are members that match this condition and then try to state-transition them all at the same time. This is what creates the IllegalOperation: invalid state transition errors.
| var member = localMembers.FirstOrDefault(m => m.Address == address); | ||
| if (member != null && member.Status != MemberStatus.Down) | ||
| var found = false; | ||
| foreach (var member in localMembers.Where(m => m.Address == address)) |
There was a problem hiding this comment.
Found the same type of issue with the Downing function too and made similar fixes there.
Arkatufus
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #7370
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):
Leavingif another instance of member with sameAddressis being marked asDOWN#7370