[FIX] Keep user manual selection while the search does not change - #10
Open
florian-dacosta wants to merge 1 commit into
Open
florian-dacosta wants to merge 1 commit into
florian-dacosta wants to merge 1 commit into
Conversation
The case we try to solve is the following : User search for an item. Item is selected + a filter is set no sale_name. Then the user manually select a different item. We want to keep this manual selection. Before this change, it would automatically select the originally searched item every 10 seconds
hparfr
reviewed
Mar 27, 2026
| } | ||
| // Do not apply logic if the filter (lot number) did not change, in order | ||
| // to keep manual selection from the user. (filter on -001 but then manually | ||
| // click on -002 casse) |
| builFilteredListSearch(); | ||
| } | ||
|
|
||
| var lastSearchedLot = null; |
Member
There was a problem hiding this comment.
Suggested change
| var lastSearchedLot = null; | |
| var selectedLot = null; |
lastSearchedLot: ça me semble ambiguë
| return $scope.filteredList.search = []; //no need to continue | ||
|
|
||
| $scope.filteredList.search = filterAndOrder($scope.sync.data, filter); | ||
|
|
Member
There was a problem hiding this comment.
if (lot_number == lastSearchedLot) {
// exit early
return
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The case we try to solve is the following : User search for an item. Item is selected + a filter is set no sale_name. Then the user manually select a different item. We want to keep this manual selection. Before this change, it would automatically select the originally searched item every 10 seconds