feat: option for app-controller Deployment instead of StatefulSet #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Marquis <[email protected]>
jessesuen
reviewed
Oct 8, 2024
Comment on lines
+1
to
+3
| {{- if .Values.controller.deployment }} | ||
| apiVersion: apps/v1 | ||
| kind: Deployment |
There was a problem hiding this comment.
Instead of having a whole new file, would it not be easier to change the kind based on the {{- if .Values.controller.deployment }} ?
There was a problem hiding this comment.
I agree it would be much easier. However I wanted to have a clear separation between the Deployment & StatefulSet, specifically if the number of replicas was increased beyond 1 and dynamicClusterDistribution was not enabled.
I'm happy to make the suggested changes if that makes more sense.
jessesuen
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #54