Allow custom client names (drop hardcodded refs to FXChainPlayer)#2
Open
rursache wants to merge 1 commit into
Open
Allow custom client names (drop hardcodded refs to FXChainPlayer)#2rursache wants to merge 1 commit into
rursache wants to merge 1 commit into
Conversation
the name the receiver shows on its pairing/PIN dialog and as the AirPlay source was hardcoded to "FXChainPlayer". add setClientName() and route the three X-Apple-Client-Name headers + the AP2 SETUP name through it, defaulting to "airplay2-sender-cpp".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the name the receiver shows on its pairing/PIN dialog (and as the AirPlay source) is hardcoded to "FXChainPlayer", noticed it on the apple tv and its a bit odd seeing someone elses app name when its not your app
adds
setClientName()and routes the threeX-Apple-Client-Nameheaders plus the AP2 SETUPnamethrough it, defaults to "airplay2-sender-cpp" and an empty string falls back to that. nothing else touchedbranched off main so its independent of the m1 PR #1