Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip leave signal randomly when SnapshotHandle::leave followed by a SnapshotHandle::shutdown immediately. #20

Merged
merged 10 commits into from
Apr 15, 2024

Conversation

al8n
Copy link
Owner

@al8n al8n commented Apr 14, 2024

No description provided.

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Merging #20 (e606e3a) into main (ffaaba2) will increase coverage by 0.46%.
The diff coverage is 90.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   67.79%   68.25%   +0.46%     
==========================================
  Files          36       36              
  Lines        4347     4354       +7     
==========================================
+ Hits         2947     2972      +25     
+ Misses       1400     1382      -18     
Files Coverage Δ
core/src/key_manager.rs 61.15% <100.00%> (+10.74%) ⬆️
core/src/lib.rs 81.81% <100.00%> (+4.04%) ⬆️
core/src/serf/api.rs 61.04% <ø> (+0.37%) ⬆️
core/src/snapshot.rs 73.04% <88.23%> (+0.42%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffaaba2...e606e3a. Read the comment docs.

@al8n al8n merged commit 7198d5d into main Apr 15, 2024
9 of 11 checks passed
@al8n al8n deleted the fix-ci branch April 15, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant