fix and update test suite #30
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a failing tests, removes all deprecation and warning from the test suite. It also makes the code more consistent by adding return types to every methods.
Other improvements made are:
assertCount(x, y)
instead ofassertEquals(x, count(y))
for clarity.MyClass::class
rather than\\Namespace\\MyClass
when asserting the instance of a class.assertRegExp
toassertMatchesRegularExpression
as the former is deprecated is PHPUnit 10+.require
statement in favor of proper namespace imports.I would also be happy to add a GitHub workflow to replace the travis pipeline if this is something you’d like to do.