feat(cloudflare/container): support image-only containers without a main entrypoint#579
Closed
agcty wants to merge 1 commit into
Closed
feat(cloudflare/container): support image-only containers without a main entrypoint#579agcty wants to merge 1 commit into
agcty wants to merge 1 commit into
Conversation
Contributor
|
Solving same problem as #583 ? Made a comment on how i think the DX should look here #583 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cloudflare.ContainerApplicationcurrently fails withContainer requires a \main` entrypoint.even when thedockerfileprop fully describes the image. That blocks containers backed by prebuilt service images — e.g.cloudflare/sandboxorghcr.io/drizzle-team/gatewayattached to a Durable Object namespace — where there is no JS program to bundle and the image's ownENTRYPOINT/CMD` should run.Change
mainis now optional whendockerfileis provided; omitting both still fails with a clear error (Container requires a \main` entrypoint or a `dockerfile`.`).WORKDIR/COPY/ENTRYPOINTstatements are appended, so the image's own entrypoint runs. The build-and-push flow is unchanged otherwise (the context just contains only the Dockerfile).sha256Objectdrops the undefinedbundleHashkey).entrypoint/commandconfiguration overrides keep working for both paths.Cloudflare.Container(the platform/layer form) is unaffected — its props still requiremain.Example:
Validation
bun tsc -bclean.packages/alchemy/test/Cloudflareyet; happy to add one if you can point me at the preferred seam for docker-dependent paths.🤖 Generated with Claude Code