feat(aws/kms): add key and alias resources#641
Merged
Conversation
Tests: - bun --check packages/alchemy/src/AWS/KMS/Key.ts packages/alchemy/src/AWS/KMS/Alias.ts packages/alchemy/src/AWS/KMS/index.ts packages/alchemy/src/AWS/index.ts packages/alchemy/src/AWS/Providers.ts packages/alchemy/test/AWS/KMS/Key.test.ts - bunx oxfmt packages/alchemy/src/AWS/KMS/Key.ts packages/alchemy/src/AWS/KMS/Alias.ts packages/alchemy/src/AWS/KMS/index.ts packages/alchemy/src/AWS/index.ts packages/alchemy/src/AWS/Providers.ts packages/alchemy/test/AWS/KMS/Key.test.ts --check - bunx oxlint packages/alchemy/src/AWS/KMS/Key.ts packages/alchemy/src/AWS/KMS/Alias.ts packages/alchemy/src/AWS/KMS/index.ts packages/alchemy/src/AWS/index.ts packages/alchemy/src/AWS/Providers.ts packages/alchemy/test/AWS/KMS/Key.test.ts - cd packages/alchemy && bun vitest run test/AWS/KMS/Key.test.ts --reporter=verbose - Manual smoke: verified key/alias create, update, retarget, destroy, CloudWatch Logs encryption, and Secrets Manager encryption
Contributor
|
Please remember to open the corresponding distilled PR. I pulled this down and see type errors. YOu're unknowingly modifying ./distilled a dependent git submodule when building resources. This is because of our AGENTS.md. I am doing that this time, just a FYI for follow up PRs 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
AWS.KMS.KeyandAWS.KMS.Alias.This supports creating customer managed keys, updating mutable key settings, scheduling deletion on destroy, and creating or updating aliases.
This should make encrypted AWS resources easier to model directly in Alchemy.
I’m leaving KMS bindings for a follow-up so this PR stays focused on the base resources.
Tests:
bun --checkon the changed filesbunx oxfmt --checkon the changed filesbunx oxlinton the changed filescd packages/alchemy && bun vitest run test/AWS/KMS/Key.test.ts --reporter=verbose