feat(docker): add Docker resources#649
Open
austinm911 wants to merge 27 commits into
Open
Conversation
sam-goodwin
reviewed
Jun 19, 2026
Comment on lines
+15
to
+17
| const password = yield* Config.redacted("POSTGRES_PASSWORD").pipe( | ||
| Config.withDefault(Redacted.make("alchemy-postgres")), | ||
| ); |
Contributor
There was a problem hiding this comment.
Maybe use the Random resource to generate it
Comment on lines
+52
to
+56
| const runtime = yield* Docker.Container.inspect(POSTGRES_CONTAINER).pipe( | ||
| Effect.catchTag("DockerCommandError", () => | ||
| Effect.succeed(EMPTY_RUNTIME), | ||
| ), | ||
| ); |
Contributor
There was a problem hiding this comment.
What is Docker.Container.inspect? Should this be Docker.inspectContainer?
Contributor
|
Sorry for leaving this hanging. We'll get to it ASAP |
- repoint Image.ts import from ../Build/Memo.ts to ../Command/Memo.ts (Build/ was renamed to Command/ on main) - migrate provider lifecycle ops from Effect.fnUntraced to Effect.fn to match the repo-wide stack-trace migration (b9676c5) - register docker-postgres-example workspace in bun.lock Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Image now auto-generates its repository name via createPhysicalName (stack/stage/logical-id/instance-id) when no name is given, matching Container/Volume/Network. The resolved name is carried on props.name so the sync ref helpers stay deterministic across reconcile/diff/read. - Source Image.builtAt / RemoteImage.createdAt from Docker's reported `Created` timestamp (new imageCreatedAt helper) instead of Date.now(); reconcile inspects the built/tagged image for both id and creation time. - Wrap process.cwd() in Effect.sync. - Tests rely on engine-generated physical names instead of Date.now() names; adoption tests use deterministic constants with rm-before. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Summary
Summary
alchemy/Dockerwith DockerImage,RemoteImage,Container,Volume, andNetworkresourcesexamples/docker-postgresCloudflare.ContainerVerification
bun vitest run test/Docker/DockerApi.test.ts test/Docker/Docker.integration.test.tsbun tsgo --noEmit -p tsconfig.jsonbun run --filter docker-postgres-example buildbunx oxlint packages/alchemy/src/Docker packages/alchemy/test/Docker packages/alchemy/package.json examples/docker-postgresbunx oxfmt --check packages/alchemy/src/Docker packages/alchemy/test/Docker packages/alchemy/package.json examples/docker-postgresbun docs:genbun run docs:checkbun run docs:buildgit diff --checkNote:
bun run docs:buildsucceeds but emits the existing NodeDEP0190child-process warning.