fix(runtime): drop tag from digest-pinned docker pull refs#70
Merged
john-royal merged 2 commits intoJul 20, 2026
Conversation
Docker's containerd image store rejects combined repo:tag@digest pull refs with "cannot overwrite digest", which breaks pulling the egress interceptor sidecar (cloudflare/proxy-everything:3cb1195@sha256:...) on hosts using the containerd store. The digest fully pins the image, so the tag is dropped when both are present. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Please add a test that would have failed prior to this change |
Exercises the pull path via a recording ChildProcessSpawner stub: fails prior to the fix (spawned argv carried the combined repo:tag@digest ref) and asserts the follow-up docker-tag alias keeps the original uri. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Done — added a behavioral test through Red/green verified against this branch:
🤖 Generated with Claude Code |
john-royal
changed the title
john-royal
pushed a commit
that referenced
this pull request
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
docker pull repo:tag@digestfails on hosts using Docker's containerd image store with:The runtime hits this when pulling the egress-interceptor sidecar — its default ref combines tag and digest (
cloudflare/proxy-everything:3cb1195@sha256:0ef6716c…,Docker.tsContainerEgressInterceptorImage) — so anyenableInternetcontainer fails on first pull on such hosts (containerd store is the default on fresh Docker Desktop installs).Fix
The digest fully pins the image, so the tag is dropped when both are present:
toPullRefstrips:tagonly when immediately followed by@sha256:(registry ports are preserved — covered by tests). Extracted as an exported helper with unit tests intest/Docker.test.ts(4 cases: tag@digest, tag-only, digest-only, registry-with-port).We've been running this as a local patch since 0.12.2; also just filed alchemy-run/alchemy#856 for a separate local-dev issue.
🤖 Generated with Claude Code