fix(runtime): owner-aware registry entry removal#72
Merged
Conversation
…s typed error/requirement channels The dts bundler cannot name the inferred Credentials requirement from @distilled.cloud/cloudflare and degraded make/layer (and everything composed from them, e.g. RuntimeServices.layerRuntime) to any/any. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A replacement instance of the same script re-registers under the same
registry key. When the superseded instance's scope closes afterwards (a
make-before-break handoff), its unregister finalizer previously deleted
{scriptName}.json — unregistering the live replacement and breaking
cross-script resolution. Removal (both the scope finalizer and the exit
hook) now only deletes the file while it still holds that write's content.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Install the packages built from this commit: @distilled.cloud/cloudflare-rolldown-plugin bun add https://pkg.distilled.cloud/cloudflare-rolldown-plugin/6c2eebb@distilled.cloud/cloudflare-runtime bun add https://pkg.distilled.cloud/cloudflare-runtime/6c2eebb@distilled.cloud/cloudflare-vite-plugin bun add https://pkg.distilled.cloud/cloudflare-vite-plugin/6c2eebb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A replacement instance of the same script re-registers under the same registry key. When the superseded instance's scope closes afterwards (a make-before-break handoff), its unregister finalizer deleted
{scriptName}.json— unregistering the live replacement and breaking cross-script resolution.Removal (both the scope finalizer and the exit hook) is now owner-aware — it only deletes the file while it still holds that write's content:
This unblocks reordering alchemy's local dev serve path back to make-before-break (start the replacement workerd before tearing down the previous instance), which alchemy-run/alchemy#812 had inverted precisely because unregister could delete the replacement registration. See alchemy-run/alchemy#859.