Skip to content

fix: remove duplicate pure annotation for rolldown 1.1.0 compat#322

Open
john-royal wants to merge 9 commits into
mainfrom
john/pure-annotation-fix
Open

fix: remove duplicate pure annotation for rolldown 1.1.0 compat#322
john-royal wants to merge 9 commits into
mainfrom
john/pure-annotation-fix

Conversation

@john-royal

Copy link
Copy Markdown
Contributor

I tried updating Alchemy to use Rolldown 1.1.0, which caused bundling to always fail with this error:

../../node_modules/.bun/@distilled.cloud+aws@0.23.1+1ccbc7ebc433c9b1/node_modules/@distilled.cloud/aws/lib/services/ec2.js (21467:14) [INVALID_ANNOTATION] A comment "/*#__PURE__*/" in "../../node_modules/.bun/@distilled.cloud+aws@0.23.1+1ccbc7ebc433c9b1/node_modules/@distilled.cloud/aws/lib/services/ec2.js" contains an annotation that Rolldown cannot interpret due to the position of the comment.
       ╭─[ ../../node_modules/.bun/@distilled.cloud+aws@0.23.1+1ccbc7ebc433c9b1/node_modules/@distilled.cloud/aws/lib/services/ec2.js:21467:15 ]
       │
 21467 │ /*@__PURE__*/ /*#__PURE__*/ S.String;
       │               ──────┬──────  
       │                     ╰──────── comment ignored due to position
       │ 
       │ Help: For more information on how to use pure annotations correctly, check the documentation: https://rolldown.rs/in-depth/dead-code-elimination#pure

Looks like the duplicate pure annotations don't play nicely with Rolldown. I wouldn't be surprised if this was affecting our tree-shaking performance before, but this should patch it.

I did a global find-and-replace of the duplicate pure annotations, so wouldn't be surprised if I messed something up.

@alchemy-version-bot

alchemy-version-bot Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Install the packages built from this commit:

@distilled.cloud/core

bun add @distilled.cloud/core@https://pkg.distilled.cloud/core/6f45908

@distilled.cloud/aws

bun add @distilled.cloud/aws@https://pkg.distilled.cloud/aws/6f45908

@distilled.cloud/axiom

bun add @distilled.cloud/axiom@https://pkg.distilled.cloud/axiom/6f45908

@distilled.cloud/azure

bun add @distilled.cloud/azure@https://pkg.distilled.cloud/azure/6f45908

@distilled.cloud/cloudflare

bun add @distilled.cloud/cloudflare@https://pkg.distilled.cloud/cloudflare/6f45908

@distilled.cloud/coinbase

bun add @distilled.cloud/coinbase@https://pkg.distilled.cloud/coinbase/6f45908

@distilled.cloud/expo-eas

bun add @distilled.cloud/expo-eas@https://pkg.distilled.cloud/expo-eas/6f45908

@distilled.cloud/fly-io

bun add @distilled.cloud/fly-io@https://pkg.distilled.cloud/fly-io/6f45908

@distilled.cloud/gcp

bun add @distilled.cloud/gcp@https://pkg.distilled.cloud/gcp/6f45908

@distilled.cloud/kubernetes

bun add @distilled.cloud/kubernetes@https://pkg.distilled.cloud/kubernetes/6f45908

@distilled.cloud/mongodb-atlas

bun add @distilled.cloud/mongodb-atlas@https://pkg.distilled.cloud/mongodb-atlas/6f45908

@distilled.cloud/neon

bun add @distilled.cloud/neon@https://pkg.distilled.cloud/neon/6f45908

@distilled.cloud/planetscale

bun add @distilled.cloud/planetscale@https://pkg.distilled.cloud/planetscale/6f45908

@distilled.cloud/posthog

bun add @distilled.cloud/posthog@https://pkg.distilled.cloud/posthog/6f45908

@distilled.cloud/prisma-postgres

bun add @distilled.cloud/prisma-postgres@https://pkg.distilled.cloud/prisma-postgres/6f45908

@distilled.cloud/stripe

bun add @distilled.cloud/stripe@https://pkg.distilled.cloud/stripe/6f45908

@distilled.cloud/supabase

bun add @distilled.cloud/supabase@https://pkg.distilled.cloud/supabase/6f45908

@distilled.cloud/turso

bun add @distilled.cloud/turso@https://pkg.distilled.cloud/turso/6f45908

@distilled.cloud/typesense

bun add @distilled.cloud/typesense@https://pkg.distilled.cloud/typesense/6f45908

@distilled.cloud/workos

bun add @distilled.cloud/workos@https://pkg.distilled.cloud/workos/6f45908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant