fix: remove duplicate pure annotation for rolldown 1.1.0 compat#322
Open
john-royal wants to merge 9 commits into
Open
fix: remove duplicate pure annotation for rolldown 1.1.0 compat#322john-royal wants to merge 9 commits into
john-royal wants to merge 9 commits into
Conversation
Contributor
|
Install the packages built from this commit: @distilled.cloud/core bun add @distilled.cloud/core@https://pkg.distilled.cloud/core/6f45908@distilled.cloud/aws bun add @distilled.cloud/aws@https://pkg.distilled.cloud/aws/6f45908@distilled.cloud/axiom bun add @distilled.cloud/axiom@https://pkg.distilled.cloud/axiom/6f45908@distilled.cloud/azure bun add @distilled.cloud/azure@https://pkg.distilled.cloud/azure/6f45908@distilled.cloud/cloudflare bun add @distilled.cloud/cloudflare@https://pkg.distilled.cloud/cloudflare/6f45908@distilled.cloud/coinbase bun add @distilled.cloud/coinbase@https://pkg.distilled.cloud/coinbase/6f45908@distilled.cloud/expo-eas bun add @distilled.cloud/expo-eas@https://pkg.distilled.cloud/expo-eas/6f45908@distilled.cloud/fly-io bun add @distilled.cloud/fly-io@https://pkg.distilled.cloud/fly-io/6f45908@distilled.cloud/gcp bun add @distilled.cloud/gcp@https://pkg.distilled.cloud/gcp/6f45908@distilled.cloud/kubernetes bun add @distilled.cloud/kubernetes@https://pkg.distilled.cloud/kubernetes/6f45908@distilled.cloud/mongodb-atlas bun add @distilled.cloud/mongodb-atlas@https://pkg.distilled.cloud/mongodb-atlas/6f45908@distilled.cloud/neon bun add @distilled.cloud/neon@https://pkg.distilled.cloud/neon/6f45908@distilled.cloud/planetscale bun add @distilled.cloud/planetscale@https://pkg.distilled.cloud/planetscale/6f45908@distilled.cloud/posthog bun add @distilled.cloud/posthog@https://pkg.distilled.cloud/posthog/6f45908@distilled.cloud/prisma-postgres bun add @distilled.cloud/prisma-postgres@https://pkg.distilled.cloud/prisma-postgres/6f45908@distilled.cloud/stripe bun add @distilled.cloud/stripe@https://pkg.distilled.cloud/stripe/6f45908@distilled.cloud/supabase bun add @distilled.cloud/supabase@https://pkg.distilled.cloud/supabase/6f45908@distilled.cloud/turso bun add @distilled.cloud/turso@https://pkg.distilled.cloud/turso/6f45908@distilled.cloud/typesense bun add @distilled.cloud/typesense@https://pkg.distilled.cloud/typesense/6f45908@distilled.cloud/workos bun add @distilled.cloud/workos@https://pkg.distilled.cloud/workos/6f45908 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried updating Alchemy to use Rolldown 1.1.0, which caused bundling to always fail with this error:
Looks like the duplicate pure annotations don't play nicely with Rolldown. I wouldn't be surprised if this was affecting our tree-shaking performance before, but this should patch it.
I did a global find-and-replace of the duplicate pure annotations, so wouldn't be surprised if I messed something up.