Skip to content

test: update to latest rundler for use with prool #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moldy530
Copy link
Collaborator

@moldy530 moldy530 commented May 28, 2025

Pull Request Checklist


PR-Codex overview

This PR focuses on updating the rundler version, modifying workspace configurations, and refactoring test instances and imports. It also introduces new functionalities and optimizations in various test files and configurations.

Detailed summary

  • Updated tag in .github/workflows/on-pull-request.yml from v0.2.2 to v0.8.2.
  • Changed workspace definition in vitest.workspace.ts to include .vitest.
  • Refactored rundler imports in .vitest/globalSetup.ts to point to ./src/rundler/binary.
  • Adjusted version in downloadLatestRundlerRelease to v0.8.2.
  • Replaced local070Instance and local060Instance with localInstance in multiple test files.
  • Added new rundlerOptions function in .vitest/src/rundler/instance.test.ts.
  • Introduced toArgs and toFlagCase functions in .vitest/src/rundler/toArgs.ts.
  • Updated test setup in setupTests.ts to use localInstance.
  • Enhanced test descriptions and scenarios in various test files for better clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 3:51pm

Copy link
Collaborator Author


How to use the Graphite Merge Queue

Add the label graphite-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented May 28, 2025

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview May 29, 2025, 3:48 PM

@github-actions github-actions bot temporarily deployed to docs-preview May 28, 2025 19:21 Inactive
@moldy530 moldy530 force-pushed the moldy/update-rundler-prool branch from d60aaaf to 3754868 Compare May 28, 2025 19:22
@github-actions github-actions bot temporarily deployed to docs-preview May 28, 2025 19:23 Inactive
@moldy530 moldy530 force-pushed the moldy/update-rundler-prool branch from 3754868 to 2256f56 Compare May 28, 2025 19:23
@github-actions github-actions bot temporarily deployed to docs-preview May 28, 2025 19:24 Inactive
@moldy530 moldy530 force-pushed the moldy/update-rundler-prool branch from 2256f56 to 1e9fe67 Compare May 28, 2025 19:44
@github-actions github-actions bot temporarily deployed to docs-preview May 28, 2025 19:44 Inactive
@moldy530 moldy530 force-pushed the moldy/update-rundler-prool branch from 1e9fe67 to 0162e06 Compare May 28, 2025 19:53
@github-actions github-actions bot temporarily deployed to docs-preview May 28, 2025 19:54 Inactive
@moldy530 moldy530 force-pushed the moldy/update-rundler-prool branch from 0162e06 to 1f09416 Compare May 28, 2025 21:06
@github-actions github-actions bot temporarily deployed to docs-preview May 28, 2025 21:07 Inactive
@moldy530 moldy530 force-pushed the moldy/update-rundler-prool branch from 1f09416 to dc2d975 Compare May 28, 2025 22:29
@github-actions github-actions bot temporarily deployed to docs-preview May 28, 2025 22:29 Inactive
@moldy530 moldy530 force-pushed the moldy/update-rundler-prool branch from dc2d975 to ef17633 Compare May 28, 2025 22:53
@github-actions github-actions bot temporarily deployed to docs-preview May 28, 2025 22:53 Inactive
@moldy530
Copy link
Collaborator Author

I'm gonna have to revisit this, I've spent too much time on it and the tests are less stable than they were on 0.2.2

@moldy530 moldy530 force-pushed the moldy/update-rundler-prool branch from ef17633 to 72b9d8a Compare May 29, 2025 15:46
@github-actions github-actions bot temporarily deployed to docs-preview May 29, 2025 15:46 Inactive
@moldy530
Copy link
Collaborator Author

splitting up the changes so i can debug more easily: #1646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant