-
Notifications
You must be signed in to change notification settings - Fork 180
feat: add use send calls hook #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add use send calls hook #1649
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
22d2016
to
9ad7468
Compare
895fe14
to
85be9fa
Compare
9ad7468
to
b027dfe
Compare
const signature = await client.signSignatureRequest( | ||
preparedCalls.signatureRequest, | ||
); | ||
|
||
const { preparedCallIds } = await client.sendPreparedCalls({ | ||
...preparedCalls, | ||
signature, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume we are going to need to handle the 7702 stuff in here too, and include the eip7702Auth
in the returned request
below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we end up doing the "multi"
signature type though, i think it would work w/ no changes here other than how we construct the returned request
: https://github.com/alchemyplatform/wallet-server/pull/187/files#diff-f9efb2f119f513d936133e68e1f0faa125d4b2b5400ec33cbc170c5ba4fcc406R46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yea this is gonna have to be updated with the breaking changes we've made for 7702
b027dfe
to
39dbd19
Compare
85be9fa
to
0b53828
Compare
39dbd19
to
4f8c06c
Compare
0b53828
to
215f8a6
Compare
4f8c06c
to
462f1f1
Compare
462f1f1
to
e1ce20d
Compare
* feat: add initial smart wallet client actions * feat: add use send calls hook (#1649) * fix: address PR comments * fix(ui-demo): update the demo app to handle correct proxy for wallet api methods * feat: add wallet client hooks (#1733) * feat(core): leverage the signer proxy for chain agnostic routes (#1742) - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- This PR focuses on enhancing the configuration management for transport connections in the `createConfig.ts` file by adding a `chainAgnosticUrl` property to the transport configuration, allowing for better handling of RPC URLs. - Added `chainAgnosticUrl` to the transport configuration in `createConfig.ts`. - Updated logic to set `chainAgnosticUrl` based on `signerConnection.rpcUrl`. - Modified tests in `store.test.ts` to verify the presence of `chainAgnosticUrl` in various configurations. - Ensured backward compatibility by using existing transport configurations when necessary. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> * fix: misc fixes from dogfooding wallet apis (#1748) * feat: port over wallet client (#1753) * chore: new package template * feat: port over client * chore: update to latest * docs: lint cleanup * test: attempt to exclude wallet client e2e from unit test runner * Revert "test: attempt to exclude wallet client e2e from unit test runner" This reverts commit a4a0fd4. * test: try to exclude bun tests again * docs: attempt at docsgen * fix: add index.mdx * fix: remove ai slop * docs: cleanup signSignatureRequest * fix: omit internal export * docs: fix session signer hoisting * fix: docs fixes * fix: fix default client retries (#1761) * fix: use workspace version of wallet client (#1762) * docs: cleanup todo * feat: support policyIds array on wallet client * feat: support multiple policyIds in wallet client (#1763) * feat: support multiple policyIds in wallet client * chore: bump wallet types --------- Co-authored-by: jakehobbs <[email protected]> Co-authored-by: Adam Egyed <[email protected]> Co-authored-by: adam <[email protected]>
* feat: add initial smart wallet client actions * feat: add use send calls hook (alchemyplatform#1649) * fix: address PR comments * fix(ui-demo): update the demo app to handle correct proxy for wallet api methods * feat: add wallet client hooks (alchemyplatform#1733) * feat(core): leverage the signer proxy for chain agnostic routes (alchemyplatform#1742) - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [ ] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [ ] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [ ] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [ ] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)? <!-- start pr-codex --> --- This PR focuses on enhancing the configuration management for transport connections in the `createConfig.ts` file by adding a `chainAgnosticUrl` property to the transport configuration, allowing for better handling of RPC URLs. - Added `chainAgnosticUrl` to the transport configuration in `createConfig.ts`. - Updated logic to set `chainAgnosticUrl` based on `signerConnection.rpcUrl`. - Modified tests in `store.test.ts` to verify the presence of `chainAgnosticUrl` in various configurations. - Ensured backward compatibility by using existing transport configurations when necessary. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> * fix: misc fixes from dogfooding wallet apis (alchemyplatform#1748) * feat: port over wallet client (alchemyplatform#1753) * chore: new package template * feat: port over client * chore: update to latest * docs: lint cleanup * test: attempt to exclude wallet client e2e from unit test runner * Revert "test: attempt to exclude wallet client e2e from unit test runner" This reverts commit a4a0fd4. * test: try to exclude bun tests again * docs: attempt at docsgen * fix: add index.mdx * fix: remove ai slop * docs: cleanup signSignatureRequest * fix: omit internal export * docs: fix session signer hoisting * fix: docs fixes * fix: fix default client retries (alchemyplatform#1761) * fix: use workspace version of wallet client (alchemyplatform#1762) * docs: cleanup todo * feat: support policyIds array on wallet client * feat: support multiple policyIds in wallet client (alchemyplatform#1763) * feat: support multiple policyIds in wallet client * chore: bump wallet types --------- Co-authored-by: jakehobbs <[email protected]> Co-authored-by: Adam Egyed <[email protected]> Co-authored-by: adam <[email protected]>
Pull Request Checklist
yarn test
)site
folder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change
)yarn lint:check
) and fix any issues? (yarn lint:write
)PR-Codex overview
This PR introduces a new
mode
property for configuration, updates the@account-kit/wallet-client
version, and refines theuseSmartWalletClient
anduseSendUserOperation
hooks to support the new mode. It also enhances type definitions and error handling in user operations.Detailed summary
mode
property increateConfig.ts
with a default value of"local"
.@account-kit/wallet-client
version from0.1.0-alpha.4
to0.1.0-alpha.6
.useSmartWalletClient
to accept a generic type for accounts.getSmartWalletClient
to utilize the newmode
parameter.useSendUserOperation
to handle new logic for user operations.useSendCalls
hook for handling calls with Smart Wallet.mode
as either"local"
or"remote"
.