-
Notifications
You must be signed in to change notification settings - Fork 5
Feat: estimated gas based on tx #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1yam
wants to merge
12
commits into
main
Choose a base branch
from
1yam-fix-estimated-gas
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
nesitor
reviewed
Apr 8, 2025
3af3f31
to
6e5e616
Compare
nesitor
previously approved these changes
May 7, 2025
6e5e616
to
d1920ab
Compare
925d2f8
to
b79866b
Compare
… Superfluid transactions
…event underfunded tx
…gas cost in _simulate_create_tx_flow
b79866b
to
2865628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we was checking native token ammount for mananging a flow we was checking based on harcoded value
0.005
, on base chain if user have a Payg running but would have only0.0045
token since base gas fees are lower, the limit should be different,To resolve this issue we use
estimate_gas
to estimate the price base on the Tx.Related ClickUp, GitHub or Jira tickets : ALEPH-496
Self proofreading checklist
Changes
This pull request includes several changes to improve transaction handling and validation in the Ethereum and Superfluid connectors. The changes primarily focus on enhancing the accuracy of transaction validation and ensuring that transactions can be simulated before execution.
Enhancements to transaction handling:
src/aleph/sdk/chains/ethereum.py
: Modified thecan_transact
method to accepttx
parameters and estimate gas for transaction validation. This ensures more accurate validation of whether a transaction can be executed.src/aleph/sdk/chains/ethereum.py
: Removed the call tocan_transact
in_sign_and_send_transaction
method, as the validation is now handled elsewhere.Improvements to Superfluid connector:
src/aleph/sdk/connectors/superfluid.py
: Added_simulate_create_tx_flow
method to simulate the creation of a Superfluid flow transaction and validate it before execution.src/aleph/sdk/connectors/superfluid.py
: Updated_execute_operation_with_account
to validate transactions using the newcan_transact
method.src/aleph/sdk/connectors/superfluid.py
: Modifiedcan_start_flow
to use_simulate_create_tx_flow
for more accurate validation of flow creation capability.