Feature: Voucher integrations #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2025
nesitor
reviewed
Aug 6, 2025
1yam
force-pushed
the
1yam-voucher-service
branch
from
ddc8f29 to
153eb97
Compare
# Conflicts: # src/aleph/sdk/types.py
1yam
force-pushed
the
1yam-voucher-service
branch
from
28567be to
5c4d9ec
Compare
nesitor
previously approved these changes
Sep 18, 2025
nesitor
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ALEPH-542
This pull request introduces a new voucher service for managing and retrieving vouchers across EVM and Solana chains, along with tests for the functionality. The most significant changes include the creation of
AuthenticatedVoucherandVouchersclasses, the addition of voucher-related types, configuration updates, and comprehensive unit tests.Voucher Service Implementation:
src/aleph/sdk/client/services/authenticated_voucher.py: Added theAuthenticatedVoucherclass, which extendsVouchers. It allows retrieval of vouchers without explicitly passing an address by using the account address as a fallback. This includes methods for fetching vouchers (get_vouchers,get_evm_vouchers,get_solana_vouchers) and resolving addresses.src/aleph/sdk/client/services/voucher.py: Introduced theVouchersclass for fetching voucher data from EVM and Solana chains. It includes utilities for resolving addresses, fetching metadata, and retrieving vouchers by chain.Voucher Types and Configuration:
src/aleph/sdk/types.py: AddedVoucher,VoucherMetadata, andVoucherAttributetypes to represent voucher data and metadata. These types encapsulate attributes like name, description, external URL, image, and traits.src/aleph/sdk/conf.py: Added configuration settings for voucher metadata URLs, Solana registry URLs, and the voucher sender address. These settings are used by the voucher services to interact with external resources.Unit Tests:
tests/unit/services/test_authenticated_voucher.py: Added tests for theAuthenticatedVoucherclass, verifying address resolution logic and voucher retrieval for both EVM and Solana chains. Tests ensure fallback mechanisms work correctly when no address is provided.tests/unit/services/test_voucher.py: Added tests for theVouchersclass, covering metadata fetching, voucher retrieval by chain, and chain detection logic for both EVM and Solana addresses.