Keep active ChatGPT workspace leases alive - #16
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90c14d3ab6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| async function startWorkspaceLeaseHeartbeat(tabId) { | ||
| if (!await touchWorkspaceLease(tabId)) return () => {}; |
There was a problem hiding this comment.
If this immediate touchWorkspaceLease rejects—for example, because of a transient chrome.storage.local.set failure—the exception escapes startWorkspaceLeaseHeartbeat, so executeInTab is never called and the ChatGPT request fails. Each tab-selection path has already established or touched the lease before reaching this helper, so this redundant renewal newly turns a recoverable heartbeat failure into a conversation failure; handle the initial renewal failure as best-effort, like the interval renewals.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Test plan