Skip to content

Add gitattributes to ignore vendored JavaScript#109

Merged
alexeichhorn merged 1 commit intomainfrom
codex/fix-project-language-classification-on-github
Oct 29, 2025
Merged

Add gitattributes to ignore vendored JavaScript#109
alexeichhorn merged 1 commit intomainfrom
codex/fix-project-language-classification-on-github

Conversation

@alexeichhorn
Copy link
Owner

Summary

  • mark bundled JavaScript helpers as vendored so Swift remains the primary language reported by GitHub

Testing

  • not run

https://chatgpt.com/codex/tasks/task_e_690148d29d18832596ba7ff10d3ab102

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

📝 Walkthrough

Walkthrough

Adds a .gitattributes rule to exclude bundled JavaScript helper files from GitHub's language statistics by marking files in Sources/YouTubeKit/Resources/*.js as vendored code.

Changes

Cohort / File(s) Change Summary
Configuration
.gitattributes
Adds linguist-vendored attribute to Sources/YouTubeKit/Resources/*.js to exclude bundled JavaScript files from GitHub language statistics

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "Add gitattributes to ignore vendored JavaScript" accurately describes the main change in the changeset, which adds a .gitattributes rule to mark bundled JavaScript helper files as linguist-vendored. The title is concise, clear, and specific enough that it conveys the primary change without unnecessary noise. A teammate reviewing the history would immediately understand that this change involves configuring git attributes to handle vendored JavaScript files.
Description Check ✅ Passed The pull request description is directly related to the changeset, explaining that bundled JavaScript helpers are being marked as vendored to ensure Swift remains the primary language reported by GitHub. This aligns with the actual change of adding a .gitattributes entry for the JavaScript files. While the description is brief and testing was not run, it provides sufficient context about the purpose of the change and is not vague or generic.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch codex/fix-project-language-classification-on-github

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 481c8e3 and b229dc5.

📒 Files selected for processing (1)
  • .gitattributes (1 hunks)
🔇 Additional comments (1)
.gitattributes (1)

1-2: Correct approach to manage GitHub language statistics.

The linguist-vendored attribute is the appropriate way to exclude bundled helper files from language classification. The pattern correctly matches the three JavaScript files in Sources/YouTubeKit/Resources/ (astring.umd.js, meriyah.umd.js, yt_ejs_helper.js), and no other JavaScript files exist outside this directory that need vendoring.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alexeichhorn alexeichhorn merged commit c6f63b7 into main Oct 29, 2025
19 checks passed
@alexeichhorn alexeichhorn deleted the codex/fix-project-language-classification-on-github branch October 29, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant