Add runtime AV1 hardware decode detection#124
Merged
alexeichhorn merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThis change introduces AV1 hardware decoding detection to the VideoCodec model by adding a private static property that queries VideoToolbox availability and platform support. The implementation replaces a hardcoded false value with runtime checks for iOS 13.0+, macOS 10.15+, and tvOS 13.0+. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@Sources/YouTubeKit/Models/Codecs.swift`:
- Around line 82-89: The availability check for kCMVideoCodecType_AV1 is too
permissive; update the guard in the isAV1HardwareDecodeSupported closure so the
runtime/compile-time availability matches the constant's introduction: keep the
canImport(VideoToolbox) check, and change the `#available` condition around the
VTIsHardwareDecodeSupported(kCMVideoCodecType_AV1) call to iOS 17.0, macOS 14.0,
and tvOS 17.0 to ensure kCMVideoCodecType_AV1 is present when referenced; leave
the fallback return false in place if the platform/SDK isn't available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect AV1 hardware support at runtime. This means we find more
isNativelyPlayablestreams on AV1-capable devices.