forked from sergey-miryanov/erlang-sqlite3
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hex.pm release #44
Open
mremond
wants to merge
51
commits into
alexeyr:master
Choose a base branch
from
processone:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
hex.pm release #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{files, ["src/", "include/", "c_src/sqlite3_drv.c", "c_src/sqlite3_drv.h", "sqlite3_amalgamation/shell.c", "sqlite3_amalgamation/sqlite3.c", "sqlite3_amalgamation/sqlite3.h", "sqlite3_amalgamation/sqlite3ext.h", "rebar.config", "README.md", "LICENSE"]}, | ||
{licenses, ["EPL 1.1"]}, | ||
{maintainers, ["alexeyr", "ProcessOne"]}, | ||
{links, [{"Github", "https://github.com/processone/erlang-sqlite3"}]}]}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer this to be https://github.com/alexeyr/erlang-sqlite3/
Merge upstream fixes
Update Travis setup to compile with up to 23.0. Update Rebar
Handle rebar3 version strings such as "3.14.1+build.4750.refd11ceb4f"
On macos (darwin), sqlite3 is embedded using "the amalgamation". There is therefore no need to link to the system sqlite3, and doing so can cause unexpected behaviour/failures. Also be explicit about darwin vs. non-darwin port_specs sources. rebar3 seems to get confused when compiling under eunit command sometimes
Do not link to sqlite3 on macos
And it even don't work with R25 because it doesn't load .beam compiled on older version. Fixes issue #9
Add foreign_key table constraint
actions/checkout@v4 updated from node16 to node20, which requires a recent GLIBC 2.27 or 2.28, however some old erlang container images include too old GLIBC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Alexey,
I prepared a release of sqlite3 for hex.pm (as version 1.1.5) and here is what I used to prepare the package. We needed that to release ejabberd on hex.pm as all dependencies must be on hex.pm as well.
I did submit it with following command, using rebar3 only for submission to hex.pm:
Please, let me know if you want to manage the project on hex.pm and I will transfer you the right as well.
Cheers,