fix(daemon): reject over-long socket paths with a clear error#26
Merged
Conversation
A Unix socket path longer than the platform's sun_path buffer (104 bytes on macOS/BSD, 108 on Linux) is silently truncated by the kernel on bind(), colliding otherwise-distinct daemons onto one socket file and surfacing as a bogus EADDRINUSE. Deeply-nested checkouts hit this on macOS, and the raw failure gives no hint why. IPCServer.start() now checks the resolved socket path against the platform limit before bind() and throws a clear IPC_ERROR (byte count, platform limit, offending path, remedy) — the single chokepoint both the single- and multi-location daemon flows funnel through. New exported maxSocketPathBytes() helper + tests (per-platform limits, over-long rejection).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Unix socket path longer than the platform's sun_path buffer (104 bytes on macOS/BSD, 108 on Linux) is silently truncated by the kernel on bind(), colliding otherwise-distinct daemons onto one socket file and surfacing as a bogus EADDRINUSE. Deeply-nested checkouts hit this on macOS, and the raw failure gives no hint why.
IPCServer.start() now checks the resolved socket path against the platform limit before bind() and throws a clear IPC_ERROR (byte count, platform limit, offending path, remedy) — the single chokepoint both the single- and multi-location daemon flows funnel through. New exported maxSocketPathBytes() helper + tests (per-platform limits, over-long rejection).
Summary
Changes
Testing
npm run lintpassesnpm run buildpassesnpm testpassesRelated issues