Handle file upload Mime content type (including jsonl extension) #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Related Open Issues
#521
Description
The problem was initially raised out of
jsonl
file uploading, which led to error below:Previously there was empty content-type hardcoded value while sending http parameters - https://github.com/alexrudall/ruby-openai/blob/main/lib/openai/http.rb#L91-L94
In order to fix an issue with
jsonl
file, we were patching the gem in our project, writing something like that:In scope of this PR I'm trying to handle this logic via usage of
MIME::Types
(mime-types
gem).In order to
jsonl
file to be recognised as application/json content type we had to manually register it upon project building, that's why I've createdOpenAI::MimeTypes
module, where we also call .register to register some custom types (might be extended in future).I've tested it locally, sending jsonl file for batch purposes - it've worked as expected.