Skip to content

feat(clients): flatten body parameters #4849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat(clients): flatten body parameters #4849

wants to merge 18 commits into from

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented May 13, 2025

🧭 What and Why

Flatten body parameters when possible to avoid having to wrap properties in a model.
To avoid breaking changes and avoid releasing a new major, all the new code lives under algolia/next, and the previous method are not generated anymore, they just live here.

@millotp millotp self-assigned this May 13, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented May 13, 2025

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@17' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 239eab9b429117a0340040640b04e7f52b9226ec
🍃 Generated commit 060ffac4f39291ba584f2a41cbbe2b609ee31b7a
🌲 Generated branch generated/feat/go-refacto
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1776
javascript 1643
php 1420
csharp 1414
java 1098
python 1089
ruby 821
swift 447
scala 23

@millotp millotp marked this pull request as ready for review May 30, 2025 08:01
@millotp millotp requested a review from a team as a code owner May 30, 2025 08:01
@millotp millotp requested review from Fluf22 and shortcuts May 30, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants