feat(specs): add put and delete API for compositions and rules #5282
Conversation
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
ben-kalmus
changed the title
ben-kalmus
force-pushed
the
benk/compositions/rest-api-endpoints
branch
5 times, most recently
from
bffbc7c to
72ff44d
Compare
ben-kalmus
force-pushed
the
benk/compositions/rest-api-endpoints
branch
from
ad30527 to
b2d864a
Compare
Ready to merge :) |
| '404': | ||
| $ref: '../../../common/responses/CompositionNotFound.yml' |
There was a problem hiding this comment.
| '404': | |
| $ref: '../../../common/responses/CompositionNotFound.yml' |
Same as for Composition Rules, we don't actually check the Composition exists and always just send the jobs to delete it 🤷
https://github.com/algolia/metis/blob/7ef740ee88b0cea24d2ac51045b8c77060025cd8/modules/services/api/internal/compositions/management.go#L198-L227
This is ready again, thanks for your patience :) |
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '../../../common/responses/common.yml#/taskID' |
There was a problem hiding this comment.
does this endpoint return the taskID directly ? what do you think about wrapping the response in a object like {"taskID": number} ? This way it's more future proof IMO, if you need to add a deletedAt or something else.
All the other endpoint returning a taskID wrap it in a object btw
There was a problem hiding this comment.
Thanks for catching this, indeed the response is {"taskID": <int>}
There was a problem hiding this comment.
rebased and pushed up fix
ben-kalmus
force-pushed
the
benk/compositions/rest-api-endpoints
branch
from
d9ce2b3 to
3ece02d
Compare
… (generated) [skip ci] Co-authored-by: Ben Kalmus <[email protected]>
…ated) algolia/api-clients-automation#5282 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Ben Kalmus <[email protected]>
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
/1/compositions/{compositionID}/for Compositions/1/compositions/{compositionID}/rules/{ruleID}for Composition Rules🧪 Test
CI