feat: first/last valid on SendTransactionParams #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdmoore
reviewed
Jun 21, 2024
robdmoore
reviewed
Jun 21, 2024
robdmoore
approved these changes
Jun 21, 2024
joe-p
commented
Apr 30, 2025
Comment on lines
+220
to
+224
| // @ts-expect-error firstValid is marked as read only | ||
| if (sendParams?.firstValid) transaction.firstValid = sendParams.firstValid | ||
| // @ts-expect-error lastValid is marked as read only | ||
| if (sendParams?.lastValid) transaction.lastValid = sendParams.lastValid | ||
|
|
There was a problem hiding this comment.
@lempira After merging main (presumably because of SDK version bump) I had to use @ts-expect-error since the fields are marked as read-only but we need to change them
There was a problem hiding this comment.
Would we still get this if we deep clone the sendParams?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Simply adds first and last valid to SendTransactionParams