Fix data document tests in custom-elements/parser/parser-uses-registr…

…y-of-owner-document.html (web-platform-tests#8537) * Change to use DOMParser to test data document * Add test for a custom element appearing in an XMLHttpRequest response body
aliams · Dec 4, 2017 · 1f33822 · 1f33822
1 parent 6df9808
commit 1f33822
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/custom-elements/parser/parser-uses-registry-of-owner-document.html b/custom-elements/parser/parser-uses-registry-of-owner-document.html
@@ -71,17 +71,14 @@
 document.body.removeChild(iframe);
 
 test(function () {
-    var windowlessDocument = document.implementation.createHTMLDocument();
-    windowlessDocument.open();
-    windowlessDocument.write('<my-custom-element></my-custom-element>');
-    windowlessDocument.close();
+    var windowlessDocument = (new DOMParser()).parseFromString('<my-custom-element></my-custom-element>', "text/html");
 
     var instance = windowlessDocument.querySelector('my-custom-element');
 
     assert_true(instance instanceof HTMLElement);
     assert_false(instance instanceof MyCustomElement);
 
-}, 'HTML parser must use the registry of window.document in a document created by document.implementation.createHTMLDocument()');
+}, 'HTML parser must use the registry of window.document in a document created by DOMParser');
 
 test(function () {
     var windowlessDocument = document.implementation.createDocument ('http://www.w3.org/1999/xhtml', 'html', null);
@@ -108,16 +105,20 @@
 promise_test(function () {
     return new Promise(function (resolve, reject) {
         var xhr = new XMLHttpRequest();
-        xhr.open('GET', '../resources/empty-html-document.html');
+        xhr.open('GET', '../resources/my-custom-element-html-document.html');
         xhr.overrideMimeType('text/xml');
         xhr.onload = function () { resolve(xhr.responseXML); }
         xhr.onerror = function () { reject('Failed to fetch the document'); }
         xhr.send();
     }).then(function (doc) {
-        doc.documentElement.innerHTML = '<my-custom-element></my-custom-element>';
         var instance = doc.querySelector('my-custom-element');
         assert_true(instance instanceof Element);
-        assert_false(instance instanceof MyCustomElement);        
+        assert_false(instance instanceof MyCustomElement);
+
+        doc.documentElement.innerHTML = '<my-custom-element></my-custom-element>';
+        var instance2 = doc.querySelector('my-custom-element');
+        assert_true(instance2 instanceof Element);
+        assert_false(instance2 instanceof MyCustomElement);
     });
 }, 'HTML parser must use the registry of window.document in a document created by XMLHttpRequest');
 

diff --git a/custom-elements/resources/my-custom-element-html-document.html b/custom-elements/resources/my-custom-element-html-document.html
@@ -0,0 +1,6 @@
+<!DOCTYPE html>
+<html>
+<body>
+<my-custom-element></my-custom-element>
+</body>
+</html>