Skip to content

Commit

Permalink
Fix custom element registry define test
Browse files Browse the repository at this point in the history
The test relies on DOM elements with ids beind added
as properties of the window. Servo does not do this, and
this is not a best practice.

Upstreamed from servo/servo#17112 [ci skip]
  • Loading branch information
cbrewster authored and jdm committed Jun 19, 2017
1 parent f13010a commit 6b076b1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions custom-elements/custom-element-registry/define.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// https://html.spec.whatwg.org/multipage/scripting.html#element-definition

// Use window from iframe to isolate the test.
const iframe = document.getElementById("iframe");
const testWindow = iframe.contentDocument.defaultView;
const customElements = testWindow.customElements;

Expand Down

0 comments on commit 6b076b1

Please sign in to comment.