feat(server): add Pool CRUD API and Kubernetes CRD service#357
Merged
Pangjiping merged 2 commits intoalibaba:mainfrom Mar 24, 2026
Merged
feat(server): add Pool CRUD API and Kubernetes CRD service#357Pangjiping merged 2 commits intoalibaba:mainfrom
Pangjiping merged 2 commits intoalibaba:mainfrom
Conversation
- Add Pool Pydantic schemas: PoolCapacitySpec, PoolStatus, CreatePoolRequest,
UpdatePoolRequest, PoolResponse, ListPoolsResponse
- Add PoolService backed by Kubernetes CustomObjectsApi (CRUD on
sandbox.opensandbox.io/v1alpha1 SandboxPool resources)
- Add FastAPI router: POST/GET /pools, GET/PUT/DELETE /pools/{pool_name}
- Return HTTP 501 for non-Kubernetes runtimes
- Add error code constants: K8S_POOL_NOT_FOUND, K8S_POOL_ALREADY_EXISTS,
K8S_POOL_API_ERROR, K8S_POOL_NOT_SUPPORTED
- Add 63 tests (29 unit + 34 integration)
wangdengshan
requested review from
Generalwin,
Pangjiping,
hittyt and
jwx0925
as code owners
Collaborator
|
Thanks for your submission! We are currently evaluating and working on this. I will merge this PR after reviewing it, and then implement complete pool CRUD functionality on top of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PoolCapacitySpec,PoolStatus,CreatePoolRequest,UpdatePoolRequest,PoolResponse,ListPoolsResponsePoolServicebacked by KubernetesCustomObjectsApi(CRUD onsandbox.opensandbox.io/v1alpha1SandboxPool resources)POST/GET /pools,GET/PUT/DELETE /pools/{pool_name}K8S_POOL_NOT_FOUND,K8S_POOL_ALREADY_EXISTS,K8S_POOL_API_ERROR,K8S_POOL_NOT_SUPPORTEDTesting
Breaking Changes
Checklist