feat(sdks): client sandbox pool implementation by ninan-nn · Pull Request #393 · alibaba/OpenSandbox

ninan-nn · 2026-03-09T09:16:39Z

Summary

Implement Kotlin SDK SandboxPool with client-side idle buffer management and configurable acquire policy (FAIL_FAST / DIRECT_CREATE).
Add pool domain model and extensibility points: PoolConfig, PoolCreationSpec, PoolSnapshot, PoolState, PoolStateStore, and InMemoryPoolStateStore.
Add reconcile loop with leader-gated replenish behavior for distributed deployments, including:
- primary lock acquire/renew flow
- stale idle fallback handling
- degraded state/backoff tracking
- lock-loss guard during putIdle
- best-effort orphan cleanup callback on lock-loss window
Improve lifecycle/concurrency safety in SandboxPool:
- periodic reconcile tick exception guard (prevents scheduler from silently stopping)
- resize vs shutdown race handling (RejectedExecutionException safe path)
- graceful shutdown waits for local in-flight operations (bounded by drainTimeout)
Remove @Deprecated annotation from SandboxPool to align with README guidance while keeping feature marked experimental in docs.
Update Kotlin SDK README (EN/ZH) with pool usage and distributed-store expectations.
Add/extend tests:
- Kotlin unit tests for reconciler/store/pool behavior (including distributed-lock edge cases)
- Java pool E2E coverage:
  - existing single-node pool suite
  - new pseudo-distributed suite with shared in-process distributed-like store

Testing

Not run (explain why)
Unit tests
Integration tests
e2e / manual verification

Executed:

cd sdks/sandbox/kotlin && ./gradlew spotlessApply build
cd tests/java && ./gradlew test --tests "*SandboxPool*E2ETest"

Result summary:

SandboxPoolSingleNodeE2ETest: 15/15 passed
SandboxPoolPseudoDistributedE2ETest: 7/7 passed

Breaking Changes

None
Yes (describe impact and migration path)

Checklist

Linked Issue or clearly described motivation
Added/updated docs (if needed)
Added/updated tests (if needed)
Security impact considered
Backward compatibility considered

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ecdc1f260

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/pool/SandboxPool.kt

...andbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/pool/PoolReconciler.kt

...box/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/domain/pool/PoolConfig.kt

hittyt · 2026-03-17T04:15:47Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75ca5a84db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/pool/SandboxPool.kt

hittyt

LGTM

Pangjiping

LGTM

Pangjiping

LGTM

jwx0925 · 2026-03-21T00:36:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c776ed674

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/pool/SandboxPool.kt

Pangjiping

LGTM

hittyt

LGTM

ninan-nn force-pushed the feature/client_pool_impl branch 11 times, most recently from 543d870 to 991e526 Compare March 13, 2026 03:50

ninan-nn changed the title ~~client pool impl~~ feat(sdks): client sandbox pool implementation Mar 13, 2026

ninan-nn force-pushed the feature/client_pool_impl branch from 991e526 to 9ecdc1f Compare March 13, 2026 04:06

ninan-nn marked this pull request as ready for review March 13, 2026 04:13

ninan-nn requested review from Pangjiping, hittyt and jwx0925 as code owners March 13, 2026 04:13

chatgpt-codex-connector bot reviewed Mar 13, 2026

View reviewed changes

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/pool/SandboxPool.kt Show resolved Hide resolved

...andbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/infrastructure/pool/PoolReconciler.kt Outdated Show resolved Hide resolved

ninan-nn mentioned this pull request Mar 13, 2026

How can I make Sandbox.create non-blocking when creating a sandbox? #439

Closed

jwx0925 reviewed Mar 13, 2026

View reviewed changes

...box/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/domain/pool/PoolConfig.kt Outdated Show resolved Hide resolved

ninan-nn force-pushed the feature/client_pool_impl branch from 9ecdc1f to 75ca5a8 Compare March 16, 2026 02:51

chatgpt-codex-connector bot reviewed Mar 17, 2026

View reviewed changes

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/pool/SandboxPool.kt Outdated Show resolved Hide resolved

ninan-nn force-pushed the feature/client_pool_impl branch 2 times, most recently from 3495072 to c7519f5 Compare March 17, 2026 07:21

hittyt previously approved these changes Mar 17, 2026

View reviewed changes

Pangjiping added feature New feature or request sdk/java labels Mar 17, 2026

Pangjiping previously approved these changes Mar 17, 2026

View reviewed changes

feat(sdks): client pool

9c776ed

ninan-nn dismissed stale reviews from Pangjiping and hittyt via 9c776ed March 18, 2026 02:03

ninan-nn force-pushed the feature/client_pool_impl branch from c7519f5 to 9c776ed Compare March 18, 2026 02:03

Pangjiping approved these changes Mar 18, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 21, 2026

View reviewed changes

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/pool/SandboxPool.kt Show resolved Hide resolved

sdks/sandbox/kotlin/sandbox/src/main/kotlin/com/alibaba/opensandbox/sandbox/pool/SandboxPool.kt Show resolved Hide resolved

Pangjiping approved these changes Mar 23, 2026

View reviewed changes

hittyt approved these changes Mar 23, 2026

View reviewed changes

jwx0925 merged commit f037b04 into alibaba:main Mar 24, 2026
11 checks passed

Conversation

ninan-nn commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Breaking Changes

Checklist

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hittyt commented Mar 17, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

hittyt left a comment

Choose a reason for hiding this comment

Uh oh!

Pangjiping left a comment

Choose a reason for hiding this comment

Uh oh!

Pangjiping left a comment

Choose a reason for hiding this comment

Uh oh!

jwx0925 commented Mar 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Pangjiping left a comment

Choose a reason for hiding this comment

Uh oh!

hittyt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ninan-nn commented Mar 9, 2026 •

edited

Loading