fix(proxy): properly handle query strings in sandbox proxy requests#485
Merged
Pangjiping merged 4 commits intoalibaba:mainfrom Mar 19, 2026
Merged
Conversation
Use httpx params parameter instead of embedding query string in URL to ensure proper encoding. Only pass content body for POST/PUT/PATCH methods to avoid potential issues with GET requests that should not have a body.
joaquinescalante23
requested review from
Generalwin,
Pangjiping,
hittyt and
jwx0925
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1271838dba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Update FakeAsyncClient to capture params in build_request - Update existing test to expect params separated from URL - Add test_proxy_forwards_get_request_with_query_params to verify the fix for issue alibaba#484 (GET requests failing with 400 MISSING_QUERY when using use_server_proxy)
- Include DELETE in methods that forward content body - DELETE requests may carry JSON/body payload for APIs that need it - Add test_proxy_forwards_delete_request_with_body to verify
- URL-encoded params are expected (path=%2Fworkspace not path=/workspace)
- Use client.request('DELETE', ...) instead of client.delete() for body content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes the issue where GET requests with query parameters fail through the sandbox proxy while POST requests succeed.
Problem
When
use_server_proxy=true:POST /directorieswork fineGET /files/search?path=/workspacefail with400 MISSING_QUERYRoot Cause
content=request.stream()was passed for all methods including GET, which should not have a bodyFix
paramsparameter instead of embedding query string in URL for proper encodingVerification
Closes: #484 (proxy query parameters issue)