Skip to content

fix(server): fix failure unit test case caused by #489 #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pangjiping wants to merge 1 commit into from
Closed

fix(server): fix failure unit test case caused by #489 #513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions server/tests/k8s/test_kubernetes_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ async def test_create_sandbox_with_no_timeout_calls_provider_with_expires_at_non
assert kwargs["expires_at"] is None
assert kwargs["labels"].get(SANDBOX_MANUAL_CLEANUP_LABEL) == "true"

def test_create_sandbox_with_network_policy_passes_egress_token_and_annotations(
@pytest.mark.asyncio
async def test_create_sandbox_with_network_policy_passes_egress_token_and_annotations(
self, k8s_service, create_sandbox_request
):
create_sandbox_request.network_policy = NetworkPolicy(default_action="deny", egress=[])
Expand All @@ -245,14 +246,15 @@ def test_create_sandbox_with_network_policy_passes_egress_token_and_annotations(
"src.services.k8s.kubernetes_service.generate_egress_token",
return_value="egress-token",
):
k8s_service.create_sandbox(create_sandbox_request)
await k8s_service.create_sandbox(create_sandbox_request)

_, kwargs = k8s_service.workload_provider.create_workload.call_args
assert kwargs["egress_auth_token"] == "egress-token"
assert kwargs["egress_mode"] == EGRESS_MODE_DNS
assert kwargs["annotations"][SANDBOX_EGRESS_AUTH_TOKEN_METADATA_KEY] == "egress-token"

def test_create_sandbox_with_network_policy_passes_egress_mode_dns_nft_from_config(
@pytest.mark.asyncio
async def test_create_sandbox_with_network_policy_passes_egress_mode_dns_nft_from_config(
self, k8s_service, create_sandbox_request
):
create_sandbox_request.network_policy = NetworkPolicy(default_action="deny", egress=[])
Expand All @@ -273,7 +275,7 @@ def test_create_sandbox_with_network_policy_passes_egress_mode_dns_nft_from_conf
"src.services.k8s.kubernetes_service.generate_egress_token",
return_value="egress-token",
):
k8s_service.create_sandbox(create_sandbox_request)
await k8s_service.create_sandbox(create_sandbox_request)

_, kwargs = k8s_service.workload_provider.create_workload.call_args
assert kwargs["egress_mode"] == EGRESS_MODE_DNS_NFT
Expand Down