Skip to content

Refactor run in session#548

Merged
hittyt merged 3 commits intoalibaba:mainfrom
ninan-nn:feature/opt_run_in_session
Mar 24, 2026
Merged

Refactor run in session#548
hittyt merged 3 commits intoalibaba:mainfrom
ninan-nn:feature/opt_run_in_session

Conversation

@ninan-nn
Copy link
Collaborator

@ninan-nn ninan-nn commented Mar 24, 2026

Summary

  • align the execd runInSession contract from code / timeout_ms to command / timeout, and update the execd server handlers accordingly
  • regenerate and update SDK-facing models, then refactor Python / JavaScript / Kotlin / C# command adapters so run and runInSession share more of the streaming / SSE / exit-code handling logic
  • remove the extra Kotlin SessionAdapter layer so createSession / deleteSession go through the generated CodeInterpretingApi, and keep handwritten transport only for the streaming session run path
  • rename public session-facing SDK options from cwd to workingDirectory (working_directory in Python) while keeping the wire / generated API field as cwd
  • update unit tests and e2e coverage across Python / JavaScript / Kotlin / C# / Java for session working-directory behavior and runInSession exit-code inference

Testing

  • Not run (updating PR metadata only in this step; tests were added/updated in the branch but not executed in this session)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)
  • the affected APIs are part of the new session capability introduced in this work; existing non-session command APIs are not being broken by this PR

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@ninan-nn ninan-nn changed the title Feature/opt run in session refactor(execd): align runInSession contract and SDK adapters Mar 24, 2026
@ninan-nn ninan-nn changed the title refactor(execd): align runInSession contract and SDK adapters Refactor run in session Mar 24, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 25fb8475ab

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ninan-nn ninan-nn force-pushed the feature/opt_run_in_session branch from 25fb847 to 65bd151 Compare March 24, 2026 04:48
@Pangjiping Pangjiping added feature New feature or request component/execd sdks labels Mar 24, 2026
@ninan-nn ninan-nn force-pushed the feature/opt_run_in_session branch 2 times, most recently from 389acf3 to a451bae Compare March 24, 2026 06:32
@ninan-nn ninan-nn force-pushed the feature/opt_run_in_session branch from a451bae to e36293a Compare March 24, 2026 11:49
Copy link
Collaborator

@Pangjiping Pangjiping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hittyt hittyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hittyt hittyt merged commit 5c25163 into alibaba:main Mar 24, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants