Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1713df6a0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sdks/sandbox/python/src/opensandbox/api/lifecycle/models/sandbox_status.py
Show resolved
Hide resolved
f1713df to
577d45a
Compare
577d45a to
790c4aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nonefields in JSON responses instead of emitting explicitnullWhat This Fixes
This PR addresses the lifecycle compatibility issue behind issue #550.
Before this change,
POST /sandboxes,GET /sandboxes/{id}, andGET /sandboxescould serialize optional response fields such asmetadata,expiresAt,status.reason,status.message, andstatus.lastTransitionAtas explicit JSONnullvalues.That behavior broke older released Python SDK versions which distinguished between:
nullIn particular,
metadata: nullcould trigger client-side parsing failures during sandbox creation.After this change:
nullexpiresAtfield in responsestimeoutandimage.auth, remain documented as nullable in the specTesting
cd server && uv run pytest tests/test_routes_create_delete.py tests/test_routes_get_sandbox.py tests/test_routes_list_sandboxes.py16 passed