Skip to content

Fix: apply sequence packing loss wrapper in SFT validation #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XChen-Zero wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: apply sequence packing loss wrapper in SFT validation #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions roll/pipeline/sft/sft_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,13 @@ def val_step(self, data: DataProto):
data = data.to(current_platform.device_type)
data.meta_info["micro_batch_size"] = self.worker_config.infer_batch_size
data = self.strategy.get_data_input(data)
metrics = self.strategy.forward_step(batch=data, forward_func=self.loss_func)

loss_func = self.loss_func
if self.worker_config.use_sequence_packing:
from roll.utils.sequence_packing import SequencePackingSFTLossWrapper
loss_func = SequencePackingSFTLossWrapper(self.strategy, loss_func)

metrics = self.strategy.forward_step(batch=data, forward_func=loss_func)
output = DataProto(meta_info={"metrics": metrics}).to("cpu")
return output

Expand All @@ -68,4 +74,4 @@ def do_checkpoint(self, global_step):

def loss_func(self, data: DataProto, output_tensor: torch.Tensor):
labels = data.batch["labels"]
return self.strategy.op_compute_language_loss(output_tensor, labels)
return self.strategy.op_compute_language_loss(output_tensor, labels)